allow notifications on gcm fixes #70 #71
Conversation
|
I am assuming it error because atm gcm only takes 2 arguments |
|
Would this be accepted with the change on the gcm library? |
|
It looks like you have a syntax error. A best approach would be to let us fork your gcm library and depend on that until gcm merges your branch. I will get to this this week. Thanks! |
|
Yeah I am used to Javascript where function params are optional so I implemented it that way so it might not break but that turned out to not be the case :D the author of the lib did let know to work on it but no progress yet. If you would like some changes to the interface or something now is the time ;) |
|
So what is the progress on this? There was 1 more request on the PR to allow a ios specific key but I will add it the moment I know you will be using the fork I made. |
fixes #70
This can only be merged after alexjlockwood/gcm#10
I will keep this up to date if the gcm PR changes
As stated in the other PR, not familiar with Go so if this needs any changed let me know.